Move shared ArrayBasics code to macro file #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordyAaldering
force-pushed
the
array-basics-macros
branch
from
93b3b0d to
73f607d
Compare
JordyAaldering
changed the title
JordyAaldering
changed the title
thomas3494
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of functionality that needs to be rewritten time and time again for structs and other user-defined types, even though their implementation is the same as in ArrayBasics, albeit with a different type. Currently this is partially mitigated through the UDTtemplates macros. We can reduce code duplication and complexity by better generalising these functions. This is a first step towards that; extracting the logic of ArrayBasics to a macro file and starting to use it in Color8 and Quaternion.