Skip to content

refactor: better method names #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2023
Merged

refactor: better method names #661

merged 4 commits into from
Oct 22, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Oct 22, 2023

Summary of Changes

I've dropped the lengthy OrUndefined and OrEmpty suffixes from methods of the NodeMapper and the functions to access node properties. Instead, they now have a stream prefix if they return a stream or a get prefix/no prefix otherwise. This better aligns with the name convention of API elements provided by langium.

@github-actions
Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.07s
✅ TYPESCRIPT eslint 35 0 0 6.78s
✅ TYPESCRIPT prettier 35 0 0 2.45s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #661 (0381531) into main (45ca2a5) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #661   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         8846      8821   -25     
  Branches      1762      1762           
=========================================
- Hits          8846      8821   -25     
Files Coverage Δ
src/cli/generator.ts 100.00% <100.00%> (ø)
src/language/builtins/safe-ds-annotations.ts 100.00% <100.00%> (ø)
src/language/builtins/safe-ds-module-members.ts 100.00% <100.00%> (ø)
src/language/helpers/nodeProperties.ts 100.00% <100.00%> (ø)
src/language/helpers/safe-ds-node-mapper.ts 100.00% <100.00%> (ø)
src/language/lsp/safe-ds-formatter.ts 100.00% <100.00%> (ø)
src/language/partialEvaluation/model.ts 100.00% <100.00%> (ø)
...age/partialEvaluation/safe-ds-partial-evaluator.ts 100.00% <100.00%> (ø)
src/language/scoping/safe-ds-scope-provider.ts 100.00% <100.00%> (ø)
src/language/typing/safe-ds-class-hierarchy.ts 100.00% <100.00%> (ø)
... and 21 more

@lars-reimann lars-reimann merged commit 0157377 into main Oct 22, 2023
@lars-reimann lars-reimann deleted the cleanup branch October 22, 2023 11:23
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant