Merged
Conversation
Ensures that `statement.close` is always called on prepared statements. This fixes an issue where, when multiple threads are running different queries at the same time, we can run into a `Commands out of sync` error.
Call `#to_a` on the result so we can close the statement and still work with the result data in the caller.
Although Ruby 2.5 lets you use `ensure` in `do...end` blocks, add `begin...end` to support older Ruby versions. Change `test-runner` image to use Ruby 2.4.
jameshodgson
previously approved these changes
Dec 15, 2020
This reverts commit f0471dc.
jlongridge
reviewed
Dec 15, 2020
jlongridge
approved these changes
Dec 15, 2020
|
Code Climate has analyzed commit fc71136 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a multi-threaded situation, it was possible to get a
Commands out of syncerror due to multiple statements being open at once.This PR fixes this by ensuring that
#closeis called on each statement.So that we can still work with any results returned from a query, we call
#to_aon the result object before returning.