Ensure result.free is called when calling #execute#39
Merged
Conversation
A `Commands out of sync` error can arise if we try and execute a new query before freeing the result of a previous query. So, where we ensure we close each statement we also ensure we free the result.
Add specs that verify that we free the result, and close the statement.
samcartwrigh
previously approved these changes
Mar 11, 2021
|
Code Climate has analyzed commit 24a1e5c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
samcartwrigh
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Commands out of syncerror can arise if we try and execute a newquery before freeing the result of a previous query. So, where we ensure
we close each statement we also ensure we free the result.