Conversation
Create a mutex, and use `#synchronize` in the `#check_out` and `#check_in` methods.
rwadstein
previously approved these changes
Mar 11, 2021
Member
rwadstein
left a comment
rwadstein
left a comment
There was a problem hiding this comment.
looks good. This may be argued as a little over protective, but puts control of everything else outside of pop and push (which is supposed to be thread safe) within the bounds of a single thread until done.
Reduce cognitive complexity to fix the CI build.
samcartwrigh
approved these changes
Mar 12, 2021
|
Code Climate has analyzed commit c7983fe and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
Connectorto use a mutex, and add#synchronizeblocks around the#check_outand#check_inmethods.