Allow nil conditions in where for backward compatibility#47
Merged
marianomms merged 1 commit intomasterfrom Feb 13, 2024
Merged
Allow nil conditions in where for backward compatibility#47marianomms merged 1 commit intomasterfrom
marianomms merged 1 commit intomasterfrom
Conversation
|
Code Climate has analyzed commit fddc3b2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
albertobajo
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s1_event_service consumes this gem and recent upgrade to latest version caused ArgumentErrors because we do pass
nilvalues to theeqcondition in places.This will allow us to continue to do that provided we set the env var to skip that specific validation check.
Related:
#38