Problem with multidatabase application.

[Kuzdo]

Hi!

I have problem when in one Action I'm using few DBs. One DB I have set as default (active) in main.php, in Model I have specified getCollection method with second DB. And now the best: application counts records from good (second) DB, but is trying retrieving records from default DB:

2016-12-29T12:29:00.071+0100 I COMMAND  [conn1] command db2.$cmd command: count { count: "some_collection", limit: 0, skip: 0 } planSummary: COUNT ntoreturn:1 keyUpdates:0 writeConflicts:0 numYields:0 reslen:44 locks:{ Global: { acquireCount: { r: 2 } }, MMAPV1Journal: { acquireCount: { r: 1 } }, Database: { acquireCount: { r: 1 } }, Collection: { acquireCount: { R: 1 } } } 0ms
2016-12-29T12:29:00.074+0100 I QUERY    [conn1] query db1.some_collection query: { $query: {}, $orderby: { _id: 1 } } planSummary: EOF ntoreturn:20 ntoskip:0 nscanned:0 nscannedObjects:0 keyUpdates:0 writeConflicts:0 numYields:0 nreturned:0 reslen:20 locks:{ Global: { acquireCount: { r: 2 } }, MMAPV1Journal: { acquireCount: { r: 1 } }, Database: { acquireCount: { r: 1 } }, Collection: { acquireCount: { R: 1 } } } 0ms

@Sammaye , can you check why this happens?

[Kuzdo]

Ok, I found were is problem. Query->getDb() is selecting default DB instead correct... But I don't know how to fix it.

[Sammaye]

If I remember right it selects what currently active.

I did do something in the readme about using multiple DBs

[Kuzdo]

So, I should change active DB when I want perform query to another DB? This can't be done automatically?

[Sammaye]

Aha, actually this is a bug. It should be adding the DB name param to https://github.com/Sammaye/mongoyii-php7/blob/master/Query.php#L334 select database here

[Kuzdo]

I thought so

[Sammaye]

One way to do this is to go:

$db = Yii::app()->mogno->selectDatabase('otherdatabase');
Query()->db = $db;

[Sammaye]

But really it should be able to use the DB that is actually provided within the query initially

[Sammaye]

Actually scratch that first comment lol, since the line does a selectdatabase it will still default back

[Sammaye]

One really hacky way is that selectDatabase in the client lets you change the default https://github.com/Sammaye/mongoyii-php7/blob/master/Client.php#L218 but this neds fixing

[Kuzdo]

I was thinking to add db name param to $query->all() in Document.php

[Sammaye]

Are you querying two different dbs on the same model?

[Kuzdo]

No, in one Model i use one DB, but in one Action i have CGridView to few DBs

[Sammaye]

I would be more tempted to fix this directly in the Query model then on that line I quoted. When it does selectDatabase it is running a piece of code which links to https://github.com/Sammaye/mongoyii-php7/blob/master/Client.php#L218 which means it only selects the default database and not the one you supply to the Query.

[Kuzdo]

Please check if that fix is ok: #18

[Sammaye]

Ah yes, so you use the code I use in the readme to change the source for the model. Problem is the model may not always be there so this code will only work for one specific scenario.

Half of my thought is:

public function setDb($db)
{
    self::$db = $db
}

Then you can just do:

(new Query)->db(Yii::app()->mognodb->selectDatabase('omg2'))->...

That should cover all bases. It is a bit clunky I know but it will be compatible with all methods. Maybe there is a cleaner way you can think of?

But that's a quick thought in between of other thoughts. What do you think?