Skip to content

Remove code block splitting #21

Closed
Closed
@mxstbr

Description

@mxstbr

draft-js-code strength is handling what happens inside a code block. I think the module should focus more on that strength.

There's a lot of other modules (like the markdown or WYSIWYG plugins) that add the UX for getting into and out of code blocks. draft-js-code is awesome alongside those modules. At the moment it's in a weird spot where it doesn't help users get into code blocks but it helps them split and exit code blocks, which doesn't make much sense to me.

Rather than try to be a full-on solution for everything code, I want draft-js-code to be the go-to module for everything that happens inside of a code block.

In the next major version upgrade (1.0) I want to remove the code block splitting functionality. It's only like 4 lines of code, so the "depreciation notice" would be a note in the changelog to add those 4 lines of code to your own app manually.

If nobody objects to this plan I'll go ahead and make it happen, and then focus on inside-code-block improvements like #12 and #7!

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions