Skip to content
This repository was archived by the owner on Aug 27, 2024. It is now read-only.

Add comparing carbon date as timestamp instead date #11#12

Merged
veeeeeRySeXy merged 1 commit intomasterfrom
bug/#11-fix-comparing-carbon-objects
Mar 7, 2019
Merged

Add comparing carbon date as timestamp instead date #11#12
veeeeeRySeXy merged 1 commit intomasterfrom
bug/#11-fix-comparing-carbon-objects

Conversation

@veeeeeRySeXy
Copy link
Copy Markdown
Contributor

@veeeeeRySeXy veeeeeRySeXy commented Feb 8, 2019

Now all filters have behavior like default where conditions in Eloquent.
Fixes #11

@populov
Copy link
Copy Markdown
Contributor

populov commented Feb 11, 2019

Ideally, there should be a test for this

@VladimirBerdnik
Copy link
Copy Markdown
Contributor

Hi, guys! Any updates on this PR?

@veeeeeRySeXy
Copy link
Copy Markdown
Contributor Author

Hi, guys! Any updates on this PR?

I didn't have time to right test for it. So I will try it some time later.

@veeeeeRySeXy veeeeeRySeXy merged commit 8ec62d9 into master Mar 7, 2019
@populov
Copy link
Copy Markdown
Contributor

populov commented Mar 7, 2019

Ok, then let's merge it now (close PR), but don't close issue, and add tests later

@veeeeeRySeXy veeeeeRySeXy deleted the bug/#11-fix-comparing-carbon-objects branch March 7, 2019 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants