Skip to content

Conversation

@Helias
Copy link
Contributor

@Helias Helias commented Mar 25, 2025

What the two gh workflows do?

The e2e-test-setup is not a real e2e tests, because it does not make any assertion, it verifies partially the setup (specifically it runs php aowow --sql and php aowow --build). It's a fast way to verify the output of it, without building all the full application locally. I would like to ask you @Sarjuuk some feedback about which screenshots we could generate to verify the major AoWoW functionalities, in terms of NPCs, zones, objects and any entity we could select for this.

Note: as written in the README the wow images and mpqdata are not involved during the setup (only DBCs are), so all the images will not be present.

How to test docker

docker pull ghcr.io/helias/www-aowow:docker-setup
docker run --name aowo-docker -p 80:80 ghcr.io/helias/www-aowow:docker-setup

Visit 127.0.0.1

@Sarjuuk Sarjuuk added the Feature request i want something that is missing label Mar 27, 2025
ENV DB_USER=root
ENV DB_PASSWORD=root

RUN apt-get update && \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain, why did you decided to put few services into one container ?
Is not better to separate them as independent to each other, and then join in docker-compose.yaml configuration ?

Dockerfile should contain configuration(-s) only for concrete service(-s) — in this case only for web-application (php); other containers (like web-server (nginx/apache-httpd) or database (mysql/mariadb/etc)) should be moved outside. Services should be connected through ports, common environment, etc.

For example, what if i want to run this web-application, but use existing database server, how i have to manage to do that ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I should do one container per service.
This was more a PoC, can be surely improved

@unsektor unsektor mentioned this pull request Sep 11, 2025
11 tasks
@Sarjuuk Sarjuuk force-pushed the master branch 2 times, most recently from aeeb4b1 to c0097f3 Compare October 14, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature request i want something that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants