-
Notifications
You must be signed in to change notification settings - Fork 221
feat(docker): add pipeline and docker support #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| ENV DB_USER=root | ||
| ENV DB_PASSWORD=root | ||
|
|
||
| RUN apt-get update && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain, why did you decided to put few services into one container ?
Is not better to separate them as independent to each other, and then join in docker-compose.yaml configuration ?
Dockerfile should contain configuration(-s) only for concrete service(-s) — in this case only for web-application (php); other containers (like web-server (nginx/apache-httpd) or database (mysql/mariadb/etc)) should be moved outside. Services should be connected through ports, common environment, etc.
For example, what if i want to run this web-application, but use existing database server, how i have to manage to do that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I should do one container per service.
This was more a PoC, can be surely improved
aeeb4b1 to
c0097f3
Compare
What the two gh workflows do?
The e2e-test-setup is not a real e2e tests, because it does not make any assertion, it verifies partially the setup (specifically it runs
php aowow --sqlandphp aowow --build). It's a fast way to verify the output of it, without building all the full application locally. I would like to ask you @Sarjuuk some feedback about which screenshots we could generate to verify the major AoWoW functionalities, in terms of NPCs, zones, objects and any entity we could select for this.Note: as written in the README the wow images and mpqdata are not involved during the setup (only DBCs are), so all the images will not be present.
How to test docker
Visit 127.0.0.1