-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add KnownJacobianSparsityDetector
and KnownHessianSparsityDetector
#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is exactly how I would have coded it too, thanks for this contribution!
Are we ok with the |
I would prefer |
Let's wait until @ChrisRackauckas gives an opinion on this |
Then let me throw |
I'd go with Known. Constant or Fixed isn't really correct, because that's more information about the sparsity pattern itself rather than information about whether it's already known. I could see constant or fixed information being used as a specialization to know that you don't need to handle certain elements of conditional handling in the sparsity detection (i.e. the concolic execution of the original algorithm) if you knew that you always had a fixed pattern and don't need to take the union. |
Let's go with Known then. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Adds
KnownJacobianSparsityDetector
andKnownHessianSparsityDetector
, closing #80.