Add JET.jl static analysis tests and fix type instabilities #1131
+25
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add JET.jl as a test dependency for static analysis testing
- Add JET static analysis test to qa.jl that verifies the Optimization
module has no JET-detectable errors
- Fix `filled_spad` in adtypes.jl: add missing else clause that caused
implicit `nothing` return when both sparsity_detector and
coloring_algorithm were already set
- Fix `__solve(cache::AbstractOptimizationCache)` in solve.jl: replace
empty function body with proper error throw to prevent type instability
from implicit `nothing` return
- Fix `instantiate_function` error path in function.jl: handle case where
both `findfirst('(', ...)` and `findfirst('{', ...)` return nothing,
preventing potential runtime error
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Bug Fixes
filled_spadin adtypes.jl: Added missingelseclause that caused implicitnothingreturn when bothsparsity_detectorandcoloring_algorithmwere already set. This could cause downstream type instabilities.__solve(cache::AbstractOptimizationCache)in solve.jl: Replaced empty function body with properArgumentErrorthrow. The previous implementation returnednothingimplicitly which violated the return type annotation and caused JET to report a type conversion error.instantiate_functionerror path in function.jl: Fixed handling of edge case where bothfindfirst('(', ...)andfindfirst('{', ...)returnnothing, which would causenothing - 1to fail at runtime.New Tests
test/qa.jlthat runsJET.report_packageon the Optimization module and asserts zero errorsJET Analysis Results
After these fixes:
The remaining 11 errors in OptimizationBase are not real bugs - they occur because JET cannot track the relationship between conditional checks for
f.cons !== nothingand the definitions ofcons_oop/lagrangianvariables. At runtime, these code paths are always guarded correctly.Test Plan
cc @ChrisRackauckas
🤖 Generated with Claude Code