Skip to content

fix remake when args is a field of the struct #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2024
Merged

fix remake when args is a field of the struct #769

merged 3 commits into from
Aug 24, 2024

Conversation

oscardssmith
Copy link
Member

@oscardssmith oscardssmith commented Aug 23, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@oscardssmith oscardssmith mentioned this pull request Aug 24, 2024
Closed
@oscardssmith oscardssmith mentioned this pull request Aug 24, 2024
Open
ChrisRackauckas
ChrisRackauckas reviewed Aug 24, 2024
View reviewed changes
@ChrisRackauckas ChrisRackauckas merged commit 015079a into SciML:master Aug 24, 2024
33 of 43 checks passed
@oscardssmith oscardssmith deleted the os/fix-remake branch August 24, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscardssmith @ChrisRackauckas