Skip to content

Fixed LLama.Web error starting session #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

tonib
Copy link
Contributor

@tonib tonib commented Apr 15, 2025

This should fix #1080

InferenceOptions.SamplingPipeline now is not required. Is not sent from client. This was the main issue for #1080
Added options to debug SignalR calls at appsettings.Development.json. If you dont have this enabled, SignalR serialization errors are not logged (even with Warning level)
Changed default web model to llava-v1.6-mistral-7b.Q3_K_XS.gguf, previous one (llama-2-7b-chat.Q4_0.gguf) did no exist

InferenceOptions.SamplingPipeline now is not required. Is not sent from client
Added options to debug SignalR calls at appsettings.Development.json
Changed default web model to llava-v1.6-mistral-7b.Q3_K_XS.gguf, previous one (llama-2-7b-chat.Q4_0.gguf) did no exist
@martindevans
Copy link
Member

Thanks for looking into this

@martindevans martindevans requested a review from Copilot April 15, 2025 12:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • LLama.Web/appsettings.Development.json: Language not supported
  • LLama.Web/appsettings.json: Language not supported

@tonib
Copy link
Contributor Author

tonib commented Apr 15, 2025

I see LLama.Unittest.Native.SafeLlamaModelHandleTests.MetadataValByKey_ReturnsCorrectly failed.
Strange. I runned tests on my machine (Windows) in Debug/Release and they passed.
It seems MetadataValueByKey() in MetadataValByKey_ReturnsCorrectly returns null, but i did not changed anything related to this

@martindevans
Copy link
Member

Yeah I don't think that's your bug. I can't reproduce it locally either though :/

@martindevans
Copy link
Member

Even though the CI is failing I'll merge this one, I asked a few other maintainers and we're pretty confident the bug isn't in your changes.

@martindevans martindevans merged commit 240f06c into SciSharp:master Apr 17, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: LLamaSharp Web stopped working
2 participants