TST: Force an orientation in the lakes shapereader test #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyshp 2.2 automatically orients the shapefiles that are read in, so force an orientation while testing specific coordinates.
QuLogic
approved these changes
Apr 26, 2022
Member
|
LGTM; don't know why I forgot about this. |
Contributor
|
For info, just pushed pyshp v2.3.0, where geojson ring orientation has now been reverted back to preserving the original shapefile ring orientation (not enforcing ring orientation based on exterior/interior). See a9ba72da52743850164185dd8db5fd821494fd11 for details. Nevertheless, as discussed in #2012, the enforcement of ring orientation in this PR adds robustness against possible future adoption of RFC7946 in fiona/gdal 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyshp 2.2 automatically orients the shapefiles that are read in, so force an orientation while testing specific coordinates.
closes #2012
Alternative to PR #2022