Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6530
Note that the "proof" of the fix is to really compare
https://github.com/SciTools/iris/blob/487cc7a96cb0e48256b48f5f9c7124e9f0dc671c/lib/iris/tests/results/integration/netcdf/derived_bounds/TestBoundsFiles/test_save_primary_without_db.cdl
with
https://github.com/SciTools/iris/blob/487cc7a96cb0e48256b48f5f9c7124e9f0dc671c/lib/iris/tests/results/integration/netcdf/derived_bounds/TestBoundsFiles/test_save_primary_with_db.cdl
so .. in the second case, we get this magic extra line
Is this really ready to go ?
The main question there is, probably, more testing may be required - but can we think of any?
One thing to note : the new code is intentionally quite defensive
- i.e. things like "what if the named bounds-var doesn't exist", "what if the terms var doesn't exist"
- but a lot of that is probably not worth testing, since it may be impossible to get the saver to actually produce those cases