SS-1191: Bugfix related to environment and flavor deletion

apps/migrations/0017_alter_streamlitinstance_port.py

@@ -0,0 +1,17 @@
+# Generated by Django 5.1.1 on 2024-10-21 13:12
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("apps", "0016_tagulous_streamlitinstance_tags_streamlitinstance"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="streamlitinstance",
+            name="port",
+            field=models.IntegerField(default=8000),
+        ),
+    ]

projects/views.py

@@ -5,6 +5,7 @@
 import requests as r
 from django.apps import apps
 from django.conf import settings as django_settings
+from django.contrib import messages
 from django.contrib.auth import get_user_model
 from django.contrib.auth.decorators import login_required
 from django.core.exceptions import FieldDoesNotExist
@@ -102,7 +103,10 @@ def settings(request, project_slug):
         )
 
     environments = Environment.objects.filter(project=project)
-    apps = Apps.objects.all().order_by("slug", "-revision").distinct("slug")
+    # apps = Apps.objects.all().order_by("slug", "-revision").distinct("slug")
+    apps_with_environment_option = (
+        Apps.objects.filter(environment__isnull=False).order_by("slug", "-revision").distinct("slug")
+    )
 
     flavors = Flavor.objects.filter(project=project)
 
@@ -207,7 +211,23 @@ def delete_environment(request, project_slug):
         pk = request.POST.get("environment_pk")
         # TODO: Check that the user has permission to delete this environment.
         environment = Environment.objects.get(pk=pk, project=project)
-        environment.delete()
+
+        can_environment_be_deleted = True
+        for model_class in APP_REGISTRY.iter_orm_models():
+            if hasattr(model_class, "environment"):
+                queryset = model_class.objects.filter(environment=environment)
+                logger.error(f"{queryset}")
+                if queryset:
+                    messages.error(
+                        request,
+                        "Environment cannot be deleted because it is currently used by at least one app \
+                            (can also be a deleted app).",
+                    )
+                    can_environment_be_deleted = False
+                    break
+
+        if can_environment_be_deleted:
+            environment.delete()
 
     return HttpResponseRedirect(
         reverse(
@@ -259,7 +279,22 @@ def delete_flavor(request, project_slug):
         pk = request.POST.get("flavor_pk")
         # TODO: Check that the user has permission to delete this flavor.
         flavor = Flavor.objects.get(pk=pk, project=project)
-        flavor.delete()
+
+        can_flavor_be_deleted = True
+        for model_class in APP_REGISTRY.iter_orm_models():
+            if hasattr(model_class, "flavor"):
+                queryset = model_class.objects.filter(flavor=flavor)
+                if queryset:
+                    messages.error(
+                        request,
+                        "Flavor cannot be deleted because it is currently used by at least one app \
+                            (can also be a deleted app).",
+                    )
+                    can_flavor_be_deleted = False
+                    break
+
+        if can_flavor_be_deleted:
+            flavor.delete()
 
     return HttpResponseRedirect(
         reverse(

templates/projects/settings.html

@@ -54,6 +54,8 @@ <h3 class="h3 mb-3">Project settings</h3>
 
     <div class="col-md-9 col-xl-10 mt-4 mt-md-0">
         <div class="tab-content">
+            {% include 'common/flash_messages.html' %}
+
             <div class="tab-pane fade show active" id="projdesc" role="tabpanel">
                 <div class="card shadow border-0">
 
@@ -147,7 +149,6 @@ <h5 class="card-title mb-0">Flavors</h5>
                         </div>
                     </div>
                 </div>
-            </div>
 
             <div class="tab-pane fade" id="environments" role="tabpanel">
                 <div class="card shadow border-0">
@@ -187,23 +188,23 @@ <h5 class="card-title mb-0">Environments</h5>
                                 <div class="mb-3">
                                     <label for="environment_name">Name</label>
                                     <input type="text" name="environment_name" id="environment_name" value=""
-                                        class="form-control" />
+                                        placeholder="Lab X" class="form-control" />
                                 </div>
                                 <div class="mb-3">
                                     <label for="environment_name">Repository</label>
                                     <input type="text" name="environment_repository" id="environment_repository"
-                                        value="" class="form-control" />
+                                        placeholder="docker.io" value="" class="form-control" />
                                 </div>
                                 <div class="mb-3">
                                     <label for="environment_image">Image</label>
                                     <input type="text" name="environment_image" id="environment_image" value=""
-                                        class="form-control" />
+                                        placeholder="user/image:tag" class="form-control" />
                                 </div>
                                 <div class="mb-3">
                                     <label for="environment_app">Applies to app:</label>
                                     <select type="text" class="form-control" id="environment_app" name="environment_app"
                                         maxlength="256" required>
-                                        {% for app in apps %}
+                                        {% for app in apps_with_environment_option %}
                                         <option value="{{ app.pk }}">{{ app.name }}</option>
                                         {% endfor %}
                                     </select>
@@ -215,9 +216,6 @@ <h5 class="card-title mb-0">Environments</h5>
                     </div>
                 </div>
             </div>
-
-
-
             {% endif %}
             {% if request.user.pk == project.owner.pk or request.user.is_superuser %}
             <div class="tab-pane fade" id="delete" role="tabpanel">