SS-1190 e2e tests for gradio and streamlit app deployment #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akochari
reviewed
Nov 28, 2024
| verifyAppStatus(app_name, "Running", "public") | ||
|
|
||
| // Verify Gradio app values | ||
| cy.logf("Checking that all dash app settings were saved", Cypress.currentTest) |
Collaborator
There was a problem hiding this comment.
Suggested change
| cy.logf("Checking that all dash app settings were saved", Cypress.currentTest) | |
| cy.logf("Checking that all Gradio app settings were saved", Cypress.currentTest) |
akochari
approved these changes
Nov 28, 2024
| verifyAppStatus(app_name, "Running", "public") | ||
|
|
||
| // Verify Streamlit app values | ||
| cy.logf("Checking that all dash app settings were saved", Cypress.currentTest) |
Collaborator
There was a problem hiding this comment.
Suggested change
| cy.logf("Checking that all dash app settings were saved", Cypress.currentTest) | |
| cy.logf("Checking that all streamlit app settings were saved", Cypress.currentTest) |
|
|
||
| // check that the app is not visible under public apps | ||
| cy.visit('/apps/') | ||
| cy.get("title").should("have.text", "Apps and models | SciLifeLab Serve (beta)") |
Collaborator
There was a problem hiding this comment.
Suggested change
| cy.get("title").should("have.text", "Apps and models | SciLifeLab Serve (beta)") |
| // check that the app is not visible under public apps | ||
| cy.visit('/apps/') | ||
| cy.get("title").should("have.text", "Apps and models | SciLifeLab Serve (beta)") | ||
| cy.get('h3').should('contain', 'Public applications and models') |
Collaborator
There was a problem hiding this comment.
Suggested change
| cy.get('h3').should('contain', 'Public applications and models') |
Comment on lines
+590
to
+591
| cy.get("title").should("have.text", "Apps and models | SciLifeLab Serve (beta)") | ||
| cy.get('h3').should('contain', 'Public applications and models') |
Collaborator
There was a problem hiding this comment.
Suggested change
| cy.get("title").should("have.text", "Apps and models | SciLifeLab Serve (beta)") | |
| cy.get('h3').should('contain', 'Public applications and models') |
anondo1969
deleted the
SS-1190-Add-e2e-tests-for-gradio-and-streamlit-app-deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Source: https://scilifelab.atlassian.net/browse/SS-1190
The task is to add appropriate tests for these app types where needed in e2e tests.
Types of changes
To indicate the type of change (such as bugfix or new feature), use a github pull request label.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!