Skip to content

Conversation

@j-awada
Copy link
Contributor

@j-awada j-awada commented Feb 11, 2025

Status

To set the status of the pull request, use the built-in github feature to set the PR as Draft or Ready for review.

Description

Jira ticket: https://scilifelab.atlassian.net/browse/SS-964

A project owner may give access to their project. Notify the user via email when access is granted.

Types of changes

To indicate the type of change (such as bugfix or new feature), use a github pull request label.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@j-awada j-awada added the new feature A new feature label Feb 11, 2025
@j-awada j-awada self-assigned this Feb 11, 2025
@churnikov churnikov self-requested a review February 11, 2025 15:07
Copy link
Contributor

@churnikov churnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss the suggestions and after that it'll be lgtm

@j-awada j-awada force-pushed the SS-964-send-email-on-project-access branch from 4e8df1c to f82db88 Compare February 13, 2025 15:44
@j-awada j-awada force-pushed the SS-964-send-email-on-project-access branch from f82db88 to f4a0ba2 Compare February 13, 2025 15:50
@j-awada j-awada merged commit cc09ad9 into develop Feb 14, 2025
2 checks passed
@j-awada j-awada deleted the SS-964-send-email-on-project-access branch February 14, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants