Skip to content

Conversation

@j-awada
Copy link
Contributor

@j-awada j-awada commented Feb 18, 2025

Status

To set the status of the pull request, use the built-in github feature to set the PR as Draft or Ready for review.

Description

https://scilifelab.atlassian.net/browse/SS-889

During app creation, the user can now type in the name of a Docker image and a list of the most pulled suggestions will appear in a dropdown menu below the input field.

This PR introduces public image suggestions found on Docker hub, image suggestions from GitHub container registry will be covered in another ticket/PR.

Types of changes

To indicate the type of change (such as bugfix or new feature), use a github pull request label.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@j-awada j-awada added the new feature A new feature label Feb 18, 2025
@j-awada j-awada self-assigned this Feb 18, 2025
@j-awada j-awada requested review from akochari and hamzaimran08 and removed request for hamzaimran08 February 18, 2025 09:57
@akochari
Copy link
Collaborator

Ah, I see this is only enabled for the custom apps. It should be enabled for Custom, Gradio, Streamlit, Dash, Shiny.

@j-awada j-awada merged commit a01a52b into develop Feb 21, 2025
2 checks passed
@j-awada j-awada deleted the SS-docker-image-autosuggestion branch February 21, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants