Skip to content

Conversation

@anondo1969
Copy link
Member

Status

To set the status of the pull request, use the built-in github feature to set the PR as Draft or Ready for review.

Description

source: https://scilifelab.atlassian.net/browse/SS-1263

To reproduce:

  • Go to https://serve.scilifelab.se/apps/ and look at the total number of apps and models: 92
  • Click on “show +x” for keywords of one of the apps. The total number of apps is now 90. → should be 92
  • Click on “hide” for the keywords of this app. The total number of apps is still 90. → should be 92.

The task is to figure out why this happens and correct it.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@anondo1969 anondo1969 added the bug Something isn't working label Feb 18, 2025
@anondo1969 anondo1969 requested a review from akochari February 18, 2025 15:40
@anondo1969 anondo1969 changed the title Ss 1263 fixing number of apps displayed on public apps page SS-1263 fixing number of apps displayed on public apps page Feb 18, 2025
@anondo1969 anondo1969 marked this pull request as ready for review February 19, 2025 08:18
@anondo1969 anondo1969 self-assigned this Feb 19, 2025
@anondo1969 anondo1969 merged commit 8b66da4 into develop Feb 21, 2025
2 checks passed
@anondo1969 anondo1969 deleted the SS-1263_fixing_number_of_apps_displayed_on_Public_apps_page branch February 21, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants