Skip to content

SS 1292 More detailed app status text #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alfredeen merged 3 commits into from
Apr 2, 2025
Merged

SS 1292 More detailed app status text #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99e84ad
Display more detailed app status text when not Running. Move permissi…
alfredeen Mar 28, 2025
0714e9f
Remove some unused code
alfredeen Mar 31, 2025
6dd7109
Merge branch 'develop' into ss-1292-ui-app-status-details
alfredeen Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion templates/projects/partials/app_instances_table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<th tabindex="0" rowspan="1" colspan="1">Name</th>
<th class="d-none d-xxl-table-cell " tabindex="0" rowspan="1" colspan="1">Created</th>
<th class="" tabindex="0" rowspan="1" colspan="1">Status</th>
<th class="" tabindex="0" rowspan="1" colspan="1">Permissions</th>
<th class="d-none d-xxl-table-cell " tabindex="0" rowspan="1" colspan="1">Tags</th>
<th tabindex="0" rowspan="1" colspan="1">Actions</th>
</tr>
Expand Down Expand Up @@ -52,8 +53,9 @@
<td data-cy="appstatus-cell">
<span class="badge bg-secondary" id="status-{{ instance.app.slug }}-{{ instance.pk }}" title="" data-cy="appstatus" data-app-action="{{instance.latest_user_action}}" data-k8s-app-status="{{instance.k8s_user_app_status.status}}" >
Refreshing...
<!-- {{ instance.get_app_status }} -->
</span>
</td>
<td>
{% if instance.app.name != "MLFlow" %}
{% if instance.access %}
{% if instance.access == 'public' %}
Expand Down
8 changes: 7 additions & 1 deletion templates/projects/partials/scripts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,17 @@
const querySelector = `#status-${key}`
const elements = document.querySelectorAll(querySelector);

let statusTxt = status;

if (status != "Running" && k8sStatus != null && k8sStatus != "") {
statusTxt = status + ": " + k8sStatus;
}

// Update both the status, the class style, and data attributes
elements.forEach(element => {
const className = `badge bg-${statusGroup}`;
element.className = className;
element.innerText = status;
element.innerText = statusTxt;
element.dataset.appAction = latestUserAction;
element.dataset.k8sAppStatus = k8sStatus;
element.title = k8sStatus;
Expand Down