SS-1357 Add DJANGO_ADMIN_URL_PATH environment variable for the custom admin route
#314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… route Signed-off-by: Nikita Churikov <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request makes the Django admin URL path configurable using an environment variable, allowing the admin route to be customized without changing the code.
- Updated studio/settings.py to retrieve DJANGO_ADMIN_URL_PATH from the environment
- Modified studio/urls.py to construct the admin URL using the new setting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| studio/settings.py | Added DJANGO_ADMIN_URL_PATH with a default value "admin" |
| studio/urls.py | Updated admin route to use the configurable admin URL path |
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Nikita Churikov <[email protected]>
…min-route' into SS-1357-create-allow-list-for-admin-route # Conflicts: # studio/urls.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the Django settings and URL configuration to make the admin URL path configurable through an environment variable.
Configuration changes:
studio/settings.py: AddedDJANGO_ADMIN_URL_PATHto be retrieved from the environment variable, defaulting to "admin" if not set.URL configuration changes:
studio/urls.py: Modified the admin URL path to use theDJANGO_ADMIN_URL_PATHsetting, allowing it to be dynamically set.Types of changes
To indicate the type of change (such as bugfix or new feature), use a github pull request label.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!