Skip to content

Bug: fix latest E2E test failure on develop #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
j-awada merged 2 commits into from
Apr 3, 2025
Merged

Bug: fix latest E2E test failure on develop #315

j-awada merged 2 commits into from
Apr 3, 2025

Conversation

@j-awada
Copy link
Contributor

@j-awada j-awada commented Apr 3, 2025 •
edited
Loading

Description

Fix the failing E2E test on the develop branch.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@j-awada j-awada added the bug Something isn't working label Apr 3, 2025
@j-awada j-awada self-assigned this Apr 3, 2025
@j-awada j-awada requested a review from a team as a code owner April 3, 2025 08:05
@j-awada j-awada requested review from alfredeen and removed request for a team April 3, 2025 08:57
alfredeen
alfredeen approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@j-awada j-awada merged commit 24d85d0 into develop Apr 3, 2025
3 checks passed
@j-awada j-awada deleted the 2ba90df-e2e-error branch April 3, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alfredeen alfredeen alfredeen approved these changes

Assignees

@j-awada j-awada

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-awada @alfredeen