Skip to content

Conversation

@churnikov
Copy link
Contributor

Notice: this PR is pointed directly to the staging branch

This pull request includes changes to the apps/forms/mlflow.py file, enhancing the user interface and providing important information to users about the experimental nature of the MLFlow app feature.

User Interface Improvements:

  • apps/forms/mlflow.py: Added an HTML import from crispy_forms.layout to support the inclusion of HTML content in the form.
  • apps/forms/mlflow.py: Introduced an HTML block in the _setup_form_helper method to display an experimental feature notice and additional guidance for users.

Types of changes

To indicate the type of change (such as bugfix or new feature), use a github pull request label.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@churnikov churnikov added the bug Something isn't working label Apr 9, 2025
@churnikov churnikov requested a review from j-awada April 9, 2025 09:48
@churnikov churnikov self-assigned this Apr 9, 2025
@churnikov churnikov requested a review from a team as a code owner April 9, 2025 09:48
Copy link
Contributor

@j-awada j-awada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but why not develop branch as well?

@churnikov churnikov changed the base branch from staging to develop April 9, 2025 11:06
@churnikov churnikov merged commit fe55261 into develop Apr 9, 2025
2 checks passed
@churnikov churnikov deleted the fix/remove-subdomain-option-for-mlflow branch April 9, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants