SS-1380 MLFlow improvements #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
reviewed
Jul 4, 2025
| response = requests.get(metrics_url, timeout=5) | ||
| response.raise_for_status() | ||
| raw_metrics = response.text | ||
| except Exception as e: |
Contributor
There was a problem hiding this comment.
Would be nice to catch explicit requests exeception
Member
Author
There was a problem hiding this comment.
Thanks. Added it here.
| try: | ||
| used_bytes = get_metric_value("minio_cluster_usage_total_bytes") | ||
| total_bytes = get_metric_value("minio_cluster_capacity_usable_total_bytes") | ||
| except Exception as e: |
Contributor
There was a problem hiding this comment.
Here as as well, I'd say and have Exception as a fall back expect statement
apps/models/app_types/mlflow.py
Outdated
| ACCESS_TYPES = (("project", "Project"),) | ||
| access = models.CharField(max_length=20, default="project", choices=ACCESS_TYPES) | ||
| upload_size = 1000 # MB | ||
| mlflow_upload_size = 1000 # MB |
Contributor
There was a problem hiding this comment.
Is there a reason for this name change? I thought that it was convenient to have the same admin interface to change the upload size
Member
Author
There was a problem hiding this comment.
Overrided the upload_size field instead of using a new variable. Verified and in admin panel it shows the correct value also. Thanks.
churnikov
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review.
Description
Source: https://scilifelab.atlassian.net/browse/SS-1380
1. Upgraded the MLFlow version to 3.1.1
2. Increased the upload size to 1 GB
3. MinIO storage info is visible from the MLFlow credential page.
Types of changes
new feature
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!