Skip to content

Conversation

@vxgmichel
Copy link
Contributor

Fix issue #28

@vxgmichel vxgmichel force-pushed the security-descriptor-to-string branch 5 times, most recently from ddf422d to ba2135e Compare August 17, 2020 16:08
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #29 into master will increase coverage by 0.05%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   85.36%   85.42%   +0.05%     
==========================================
  Files          26       27       +1     
  Lines        1531     1544      +13     
==========================================
+ Hits         1307     1319      +12     
- Misses        224      225       +1     
Impacted Files Coverage Δ
src/winfspy/plumbing/security_descriptor.py 88.63% <87.50%> (-0.26%) ⬇️
src/winfspy/tests/test_security_descriptor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ece86d9...8604a03. Read the comment docs.

@vxgmichel vxgmichel requested a review from touilleMan August 17, 2020 16:32
@vxgmichel vxgmichel force-pushed the security-descriptor-to-string branch from ba2135e to 8604a03 Compare August 19, 2020 13:53
@vxgmichel vxgmichel requested a review from touilleMan August 19, 2020 14:39
Copy link
Contributor

@touilleMan touilleMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@vxgmichel vxgmichel merged commit f5abc83 into master Aug 19, 2020
@vxgmichel vxgmichel deleted the security-descriptor-to-string branch August 19, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants