[java] simplify strings processing

[iampopovich]

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

This pull request includes several changes to improve code readability and consistency in the Selenium project. The most important changes involve replacing deprecated string methods and updating header content type handling.

Improvements to code readability and consistency:

• java/src/dev/selenium/tools/modules/ModuleGenerator.java: Simplified the error message concatenation by removing unnecessary new String conversion.
• java/src/org/openqa/selenium/Cookie.java: Replaced ("".equals(path)) with path.isEmpty() for better readability.
• java/src/org/openqa/selenium/Platform.java: Replaced ("".equals(matcher)) with matcher.isEmpty() for better readability.
• java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java: Removed unnecessary toString() call on JSON_UTF_8 when setting the content type header.

Motivation and Context

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Simplified string operations for better readability.

• Replaced deprecated or redundant string methods.

• Improved header content type handling in HTTP requests.

• Enhanced error message concatenation in module processing.

---

Changes walkthrough 📝

Relevant files

Enhancement

ModuleGenerator.java Simplified error message concatenation logic                          java/src/dev/selenium/tools/modules/ModuleGenerator.java Simplified error message concatenation. Removed unnecessary new String conversion. +1/-5      Cookie.java Improved readability in cookie string representation          java/src/org/openqa/selenium/Cookie.java Replaced ("".equals(path)) with path.isEmpty(). Improved readability of cookie string representation. +1/-1      Platform.java Improved OS name matching readability                                        java/src/org/openqa/selenium/Platform.java Replaced ("".equals(matcher)) with matcher.isEmpty(). Enhanced readability in OS name matching logic. +1/-1      AbstractHttpCommandCodec.java Simplified header content type handling                                    java/src/org/openqa/selenium/remote/codec/AbstractHttpCommandCodec.java Removed unnecessary toString() call on JSON_UTF_8. Simplified header content type handling. +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Null Check The path variable is accessed without a null check in path.isEmpty(). If path can be null, this could cause a NullPointerException. + (path.isEmpty() ? "" : "; path=" + path)

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Fix error message content display Suggestion Impact: The commit implemented the suggestion by converting the ByteArrayOutputStream (bos) to a string using toString() method, but with additional improvements: using StandardCharsets.UTF_8 for proper encoding and reformatting the error message with String.format for better readability. code diff: throw new RuntimeException( - "Unable to process module:\n" + "jdeps " + String.join(" ", jdepsArgs) + "\n" + bos); + String.format( + "Unable to process module:%njdeps %s%n%s", + String.join(" ", jdepsArgs), bos.toString(StandardCharsets.UTF_8))); The error message construction should include the actual error output from the process execution, which is currently missing. Access the error content from bos using bos.toString() or new String(bos.toByteArray()). java/src/dev/selenium/tools/modules/ModuleGenerator.java [214-215] throw new RuntimeException( - "Unable to process module:\n" + "jdeps " + String.join(" ", jdepsArgs) + "\n" + bos); + "Unable to process module:\n" + "jdeps " + String.join(" ", jdepsArgs) + "\n" + bos.toString()); [Suggestion has been applied] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that the error message might not properly display the process output since 'bos' needs to be converted to a string. This could significantly impact error debugging and troubleshooting.	Medium
	Fix cookie format syntax The semicolon after 'secure' creates invalid cookie syntax. Remove the trailing semicolon to conform to cookie format standards. java/src/org/openqa/selenium/Cookie.java [280] -+ (isSecure ? ";secure;" : "") ++ (isSecure ? ";secure" : "") Apply this suggestion Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a syntax issue in cookie formatting where an extra semicolon after 'secure' could cause compatibility issues with some browsers or systems parsing the cookie string.	Medium
Update

[iampopovich]

@mk868 review please

[mk868]

@mk868 review please

I don't have permission to approve PRs in this repository.
Anyway, your changes look good to me!

[asolntsev]

LGTM

[Copilot]

Pull request overview

This pull request aims to simplify string processing in Java code by replacing verbose patterns with more readable alternatives. The changes include replacing "".equals(string) with string.isEmpty(), removing unnecessary toString() calls, and modernizing string concatenation using String.format().

Key changes:

• Replaced "".equals(path) with path.isEmpty() for better readability in Cookie and Platform classes
• Removed redundant toString() call on JSON_UTF_8 constant in AbstractHttpCommandCodec
• Modernized error message concatenation in ModuleGenerator using String.format() with explicit UTF-8 charset handling

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ModuleGenerator.java	Refactored error message concatenation to use String.format() and added StandardCharsets import for explicit UTF-8 encoding
Cookie.java	Replaced "".equals(path) with path.isEmpty() in toString() method
Platform.java	Replaced "".equals(matcher) with matcher.isEmpty() in OS name matching logic
AbstractHttpCommandCodec.java	Removed unnecessary toString() call on JSON_UTF_8 String constant

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.