Repository navigation
fix(signoff): accept removed points under the head frontier in Check 18(g) / fix(signoff):Check 18(g) 接受位于 head 前沿线下方的被移除点 #4589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) Verifiers re-checking removed points with
signoff_facts dominancecan now get a false PASS by passing only some head points asafter. Under the old rule a partial list could only fail too often._coverbuilds its segment from whateverafterit is given. If a lower non-dominated head point between the bracketing pair is left out, the line rises and a removed point above the real head curve reports "between A and B". Fix: requireafterto hold every measured head point of the config key, i.e. the facts' head measurements plus any the facts missed. Also havecheck_18g_pointsoutput the head points it used so the verifier can copy them.Why this was flagged
Check 18(g) at .github/codeowner-signoff-verify-prompt.md:934-937 tells the verifier to run
signoff_facts dominancefor unmeasured points, and to look at head measurements "the facts missed". It never says which head points go intoafter.points_diff(signoff_facts.py:442-517) does not report the full head set it fed into_cover, onlyaddedandremoved. So the verifier rebuildsafterfrom a run download, as the PR's own replays did for #4281/#4357 ("the head points of the validating run"). That leaves out unchanged head points measured only on the ingested curve. In_cover(signoff_facts.py:300-307), dropping a non-dominated head point C that sits below the A-B chord removes the A-C-B kink. The line at the removed point'smean_intvtythen rises and the point is reported as covered, even though the full head frontier fails it. On the base branchdominated_byneeded one dominating point, so a partialaftercould only cause a false FAIL, never a false PASS.Verification: Trigger: a verifier runs
signoff_facts dominancewith anafterlist that leaves out a non-dominated head point. In signoff_facts.py,_coverbuildsfrontieronly from theothersit is passed. The old rule was monotone: a subset ofaftercould never produce a false PASS. Check 18(g) at .github/codeowner-signoff-verify-prompt.md:934-937 never says thataftermust contain every measured head point.