Repository navigation
[NV] Qwen3.8-Flash-Next FP4 GB300 SGLang AgentX update / [NV] Qwen3.8-Flash-Next FP4 GB300 SGLang AgentX 更新 #4787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hshrivastava-droid
merged 8 commits into
main
from
qwen38next-gb300-sglang-agentx-public
Nov 6, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a47b65b
[NV] Qwen3.8-Flash-Next FP4 GB300 SGLang AgentX update
hshrivastava-droid d021b67
Update perf-changelog pr-link
hshrivastava-droid 5178cd3
Merge branch 'main' into qwen38next-gb300-sglang-agentx-public
hshrivastava-droid f5454c5
Update perf-changelog description
hshrivastava-droid 0b2a2de
Merge remote-tracking branch 'origin/main' into qwen38next-gb300-sgla…
hshrivastava-droid 0b1907a
Merge remote-tracking branch 'origin/main' into qwen38next-gb300-sgla…
hshrivastava-droid 1aa39c5
Merge branch 'main' into qwen38next-gb300-sglang-agentx-public
hshrivastava-droid d3d618c
Merge remote-tracking branch 'origin/main' into qwen38next-gb300-sgla…
hshrivastava-droid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 nit (optional): The new recipe comment includes past benchmark results, which the AGENTS.md comments rule does not allow in code. The phrase "they gave no gain at 36 and 56" records past results, and that history belongs in git and perf-changelog.yaml. The out-of-memory failure at concurrency 80 counts as a measured failure, so that part can stay. Fix: shorten the comment to the technical reason only, for example "Post-verify CUDA graphs captured lazily while serving exhaust GPU memory at high concurrency; compact verify sampling stays on."
Why this was flagged
The comment on the
&hicache_envanchor (agentic.yaml:185-187) explains why the post-verify CUDA graph flags are turned off for override_c36, override_c56 and override_c80. Its clause "they gave no gain at 36 and 56" reports earlier benchmark outcomes. AGENTS.md (Comments, mandatory, every file) bans comments about past results and points to git and perf-changelog.yaml as the record. It allows only technical explanations, such as a measured failure. Nothing breaks at runtime. The cost is that the recipe goes against the repo's mandatory comment convention, and the comment will go stale once the image or settings change.Verification: The diff adds this text at agentic.yaml:190-191, inside the
&hicache_envanchor under override_c36. AGENTS.md:54-58 says: "No history: how code evolved, what it replaced, where it came from, or past results." The OOM at concurrency 80 is a measured failure, so that part is allowed. "they gave no gain at 36 and 56" reports an earlier benchmark outcome. Nothing breaks at runtime.