Skip to content

[NV] MiniMax-M3.1-Flash H100 vLLM AgentX update / [NV] MiniMax-M3.1-Flash H100 vLLM AgentX 更新 - #5124

Open
hshrivastava-droid wants to merge 2 commits into
mainfrom
minimaxm31flash-h100-vllm-agentx-public
Open

hshrivastava-droid wants to merge 2 commits into
mainfrom
minimaxm31flash-h100-vllm-agentx-public

Conversation

@hshrivastava-droid

Copy link
Copy Markdown
Collaborator

Update the MiniMax-M3.1-Flash FP4 H100 vLLM AgentX config (minimaxm31flash-fp4-h100-vllm-agentic-dspark).

  • Image: vllm/vllm-openai:nightly-8ca766326652caf4b8e50d1b9118d8a22f6adc73
AI model disclosure
  • Model/version: claude-sonnet-5-5
  • Role: ported the config to this repository
PR checklist and change type

Type of Change

  • Bug fix
  • New feature
  • Configuration change
  • Documentation update
  • Other (please describe)

Checklist

  • I have completed the AI model disclosure and kept it current
  • I have tested my changes locally
  • I have updated documentation if necessary
  • If python -m infx.matrix.changed --base origin/main lists affected config keys, I have appended one new entry covering them to the physical end of inferencex-e2e/perf-changelog.yaml; if it lists none, I have added none. I have not edited historical entries
  • If this PR appends an inferencex-e2e/perf-changelog.yaml entry, it carries exactly one primary sweep label: full-sweep-enabled
  • Before merging via reuse, an authorized maintainer has commented /use <run_id> on this PR
中文

更新 MiniMax-M3.1-Flash FP4 H100 vLLM AgentX 配置(minimaxm31flash-fp4-h100-vllm-agentic-dspark)。镜像同上。

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@hshrivastava-droid
hshrivastava-droid requested a review from a team November 18, 2026 01:01
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@hshrivastava-droid hshrivastava-droid added the full-sweep-enabled Full sweep with canary gate; matrix jobs run to completion despite failures label Nov 18, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread inferencex-e2e/perf-changelog.yaml Outdated
description:
- "Update to vllm/vllm-openai:nightly-8ca766326652caf4b8e50d1b9118d8a22f6adc73, which selects FlashInfer's SM90 MSA kernels for the indexer and sparse attention."
- "Serve flags, DSpark speculation and the search space are unchanged."
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PRNUM

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The changelog merge-prep step will reject this PR, so the image bump cannot land as it is. The new entry's pr-link ends in pull/PRNUM, and PR_LINK_PLACEHOLDERS in validate_perf_changelog.py:21 accepts only XXX or .../pull/XXX. compare_entries then raises ChangelogValidationError ("new PR entry must use ... or an XXX placeholder"). Fix: set the link to the real PR URL, or to https://github.com/SemiAnalysisAI/InferenceX/pull/XXX as the CONTRIBUTING.md:213 template shows, so the merge step can fill in the canonical link.

Why this was flagged

The appended block at inferencex-e2e/perf-changelog.yaml:13004 sets pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PRNUM. When the PR is prepared for merge, prepare_perf_changelog_merge.py:88 calls compare_entries(base_entries, head_entries, pr_number). That runs validate_added_pr_link (validate_perf_changelog.py:105-116) on every appended entry. The link is not in PR_LINK_PLACEHOLDERS (only "XXX" and ".../pull/XXX"), and it does not equal .../pull/<pr_number>, so the step raises ChangelogValidationError. Even past that check, prepare_perf_changelog_merge.py:108 raises "appended entry N has unexpected pr-link" for any link outside the placeholder set. On a main-branch run, CANONICAL_PR_LINK (pull/\d+) rejects it as well. The existing 11 entries and every in-repo template use pull/XXX, and PRNUM is the only one of its kind in the file. The result is that the changelog pipeline refuses this PR's entry, and the sweep for minimaxm31flash-fp4-h100-vllm-agentic-dspark cannot be prepared or merged until the link is changed.

Verification: The diff appends pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PRNUM (perf-changelog.yaml, the final line of the new block). validate_perf_changelog.py:21-24 defines PR_LINK_PLACEHOLDERS = {"XXX", "https://github.com/SemiAnalysisAI/InferenceX/pull/XXX"}. The PRNUM link therefore raises and the merge aborts. The base has no such entry.

# MiniMax-M3.1-Flash AgentX on H100: day-zero vLLM image from
# https://vllm.ai/blog/2026-10-23-minimax-m31-flash, multiarch manifest verified
# 2026-10-23 (amd64 is minimax-m31-flash-x86_64-cu134). Serve flags follow the
# MiniMax-M3.1-Flash AgentX on H100: vLLM nightly with FlashInfer SM90 MSA. Serve flags follow the

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): The rewritten comment is a config header comment, which AGENTS.md:56 forbids. It names the image ("vLLM nightly with FlashInfer SM90 MSA") instead of explaining a specific line. It also runs well past the wrap width of the lines around it. Fix: drop the header sentence and keep only the line-level reasons. The FlashInfer MSA reason is already noted next to kv-cache-dtype in the recipe.

Why this was flagged

In nvidia-master.yaml:4133 the diff rewrites the comment above minimaxm31flash-fp4-h100-vllm-agentic-dspark to "MiniMax-M3.1-Flash AgentX on H100: vLLM nightly with FlashInfer SM90 MSA. Serve flags follow the". This newly written text is a header comment describing the config, and AGENTS.md:56 bans those ("No header comments describing a file, topology, config, recipe, override, or section"). The image tag already records what the image is. The changelog entry and the new recipe comment at agentic.yaml:38 already explain the FlashInfer MSA reason. Maintainers are left with a stale-prone header that the repo's comment rules say must not exist.

Verification: The diff replaces lines 4133-4135 of inferencex-e2e/configs/nvidia-master.yaml with a line that opens MiniMax-M3.1-Flash AgentX on H100:, a label for the config key below it. AGENTS.md:56 bans this: "No header comments describing a file, topology, config, recipe, override, or section." The rewritten line is about 99 characters, while nearby comment lines wrap near 80.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-sweep-enabled Full sweep with canary gate; matrix jobs run to completion despite failures

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant