Repository navigation
[NV] MiniMax-M3.1-Flash H100 vLLM AgentX update / [NV] MiniMax-M3.1-Flash H100 vLLM AgentX 更新 - #5124
hshrivastava-droid wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Thanks for the contribution!
中文感谢你的贡献!
|
| description: | ||
| - "Update to vllm/vllm-openai:nightly-8ca766326652caf4b8e50d1b9118d8a22f6adc73, which selects FlashInfer's SM90 MSA kernels for the indexer and sparse attention." | ||
| - "Serve flags, DSpark speculation and the search space are unchanged." | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PRNUM |
There was a problem hiding this comment.
🔴 The changelog merge-prep step will reject this PR, so the image bump cannot land as it is. The new entry's pr-link ends in pull/PRNUM, and PR_LINK_PLACEHOLDERS in validate_perf_changelog.py:21 accepts only XXX or .../pull/XXX. compare_entries then raises ChangelogValidationError ("new PR entry must use ... or an XXX placeholder"). Fix: set the link to the real PR URL, or to https://github.com/SemiAnalysisAI/InferenceX/pull/XXX as the CONTRIBUTING.md:213 template shows, so the merge step can fill in the canonical link.
Why this was flagged
The appended block at inferencex-e2e/perf-changelog.yaml:13004 sets pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PRNUM. When the PR is prepared for merge, prepare_perf_changelog_merge.py:88 calls compare_entries(base_entries, head_entries, pr_number). That runs validate_added_pr_link (validate_perf_changelog.py:105-116) on every appended entry. The link is not in PR_LINK_PLACEHOLDERS (only "XXX" and ".../pull/XXX"), and it does not equal .../pull/<pr_number>, so the step raises ChangelogValidationError. Even past that check, prepare_perf_changelog_merge.py:108 raises "appended entry N has unexpected pr-link" for any link outside the placeholder set. On a main-branch run, CANONICAL_PR_LINK (pull/\d+) rejects it as well. The existing 11 entries and every in-repo template use pull/XXX, and PRNUM is the only one of its kind in the file. The result is that the changelog pipeline refuses this PR's entry, and the sweep for minimaxm31flash-fp4-h100-vllm-agentic-dspark cannot be prepared or merged until the link is changed.
Verification: The diff appends pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/PRNUM (perf-changelog.yaml, the final line of the new block). validate_perf_changelog.py:21-24 defines PR_LINK_PLACEHOLDERS = {"XXX", "https://github.com/SemiAnalysisAI/InferenceX/pull/XXX"}. The PRNUM link therefore raises and the merge aborts. The base has no such entry.
| # MiniMax-M3.1-Flash AgentX on H100: day-zero vLLM image from | ||
| # https://vllm.ai/blog/2026-10-23-minimax-m31-flash, multiarch manifest verified | ||
| # 2026-10-23 (amd64 is minimax-m31-flash-x86_64-cu134). Serve flags follow the | ||
| # MiniMax-M3.1-Flash AgentX on H100: vLLM nightly with FlashInfer SM90 MSA. Serve flags follow the |
There was a problem hiding this comment.
🟡 nit (optional): The rewritten comment is a config header comment, which AGENTS.md:56 forbids. It names the image ("vLLM nightly with FlashInfer SM90 MSA") instead of explaining a specific line. It also runs well past the wrap width of the lines around it. Fix: drop the header sentence and keep only the line-level reasons. The FlashInfer MSA reason is already noted next to kv-cache-dtype in the recipe.
Why this was flagged
In nvidia-master.yaml:4133 the diff rewrites the comment above minimaxm31flash-fp4-h100-vllm-agentic-dspark to "MiniMax-M3.1-Flash AgentX on H100: vLLM nightly with FlashInfer SM90 MSA. Serve flags follow the". This newly written text is a header comment describing the config, and AGENTS.md:56 bans those ("No header comments describing a file, topology, config, recipe, override, or section"). The image tag already records what the image is. The changelog entry and the new recipe comment at agentic.yaml:38 already explain the FlashInfer MSA reason. Maintainers are left with a stale-prone header that the repo's comment rules say must not exist.
Verification: The diff replaces lines 4133-4135 of inferencex-e2e/configs/nvidia-master.yaml with a line that opens MiniMax-M3.1-Flash AgentX on H100:, a label for the config key below it. AGENTS.md:56 bans this: "No header comments describing a file, topology, config, recipe, override, or section." The rewritten line is about 99 characters, while nearby comment lines wrap near 80.
Update the MiniMax-M3.1-Flash FP4 H100 vLLM AgentX config (
minimaxm31flash-fp4-h100-vllm-agentic-dspark).vllm/vllm-openai:nightly-8ca766326652caf4b8e50d1b9118d8a22f6adc73AI model disclosure
PR checklist and change type
Type of Change
Checklist
python -m infx.matrix.changed --base origin/mainlists affected config keys, I have appended one new entry covering them to the physical end ofinferencex-e2e/perf-changelog.yaml; if it lists none, I have added none. I have not edited historical entriesinferencex-e2e/perf-changelog.yamlentry, it carries exactly one primary sweep label:full-sweep-enabled/use <run_id>on this PR中文
更新 MiniMax-M3.1-Flash FP4 H100 vLLM AgentX 配置(
minimaxm31flash-fp4-h100-vllm-agentic-dspark)。镜像同上。🤖 Generated with Claude Code