Repository navigation
[AMD][Qwen3.5] Run MI355X FP8 AgentX on the 20261117 image with the monokernel #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yichiche
wants to merge
5
commits into
main
Choose a base branch
from
amd/qwen35-fp8-mi355x-daily-monokernel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+13
−2
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4100fbe
[AMD][Qwen3.5] Run MI355X FP8 AgentX on the 20261116 image with the m…
yichiche 17288bd
[AMD][Qwen3.5] Point the changelog entry at PR 5099
yichiche 535befe
[AMD][Qwen3.5] Drop the comment above the monokernel flag
yichiche 1bc9d81
[AMD][Qwen3.5] Point the AgentX arm at the 20261117 image
yichiche 754e658
Re-trigger Run Sweep for full-sweep-fail-fast
yichiche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Merging this rewrites a byte in an existing changelog entry, which the repo forbids. The changelog conflict tooling treats this file as append-only. The hunk strips two trailing spaces from the previous entry's
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/5089line at perf-changelog.yaml:12920. AGENTS.md:88 says to preserve every existing byte and append only at the tail. Fix: restore the two trailing spaces on line 12920 exactly as on the base, and change only the lines after it to add the new block.Why this was flagged
The diff removes
from the end of line 12920 (pr-link: .../pull/5089), which belongs to the entry before this PR's new block. AGENTS.md:88 saysperf-changelog.yamlis append-only and byte-sensitive, and conflicts must be resolved only with the changelog conflict helper. On the base branch that line ends with two spaces, so this PR edits a historical entry rather than only appending. Another open PR that also appends after the #5089 entry will then conflict on that line, and the append-only helper and checks that assume an unchanged prefix see a modified existing byte. No safeguard in the diff keeps the old bytes, because the editor's trailing-whitespace stripping touched the context line.Verification: Trigger: any run of the repo's changelog tooling on this PR's diff. The hunk replaces
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/5089 $with...pull/5089$. infx/matrix/plan.py:62-69 raisesValueError("Deletions are not allowed in ...")for the removed non-blank line, so the PR sweep fails at validation and the post-merge ingest fails too.