Meta: Fix uutils coreutils du detection#26120
Merged
Merged
Conversation
github-actions
Bot
added
the
👀 pr-needs-review
Member
|
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
Member
|
Please configure your editor to not use Windows line endings (only LF instead of CRLF) for the commit message. |
StarterX4
force-pushed
the
fix-du-uutils-detect
branch
from
August 10, 2025 17:22
d53c247 to
a515ed3
Compare
As uutils coreutils (a Rust GNU coreutils reimplementation)
`du --help` doesn't include any information where it comes from,
but `du -V` does:
```
[starterx4@doadgrz ~]$ du -V
du (uutils coreutils) 0.1.0
```
We have to use it then to detect uutils correctly as
the BSD `-A` argument fails (uutils is not BSD-compatible):
```
error: unexpected argument '-A' found
tip: to pass '-A' as a value, use '-- -A'
Usage: du [OPTION]... [FILE]...
du [OPTION]... --files0-from=F
error: unexpected argument '-A' found
tip: to pass '-A' as a value, use '-- -A'
Usage: du [OPTION]... [FILE]...
du [OPTION]... --files0-from=F
```
Also we have to use `--apparent-size`
due to a bug with `-b` (SerenityOS#26121)
StarterX4
force-pushed
the
fix-du-uutils-detect
branch
from
August 12, 2025 10:29
a515ed3 to
f4f7e18
Compare
spholz
approved these changes
Aug 12, 2025
spholz
added
✅ pr-maintainer-approved-but-awaiting-ci
github-actions
Bot
removed
the
✅ pr-maintainer-approved-but-awaiting-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As uutils coreutils (a Rust GNU coreutils reimplementation)
du --helpdoesn't include any information where it comes from, butdu -Vdoes:We have to use it then to detect uutils correctly as the BSD
-Aargument fails (uutils is not BSD-compatible):