Skip to content

Performance update on GenerateQrCode function #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codebude merged 4 commits into from
Apr 19, 2024
Merged

Performance update on GenerateQrCode function #438

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4e82c99
Performance update on GenerateQrCode function
HolyOne Dec 24, 2022
c85200c
Update QRCoder/QRCodeGenerator.cs
codebude Apr 19, 2024
b9dad0a
Update QRCoder/QRCodeGenerator.cs
codebude Apr 19, 2024
62e32a9
Update QRCoder/QRCodeGenerator.cs
codebude Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions QRCoder/QRCodeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,16 @@ public static QRCodeData GenerateQrCode(byte[] binaryData, ECCLevel eccLevel)
string modeIndicator = DecToBin((int)EncodingMode.Byte, 4);
string countIndicator = DecToBin(binaryData.Length, GetCountIndicatorLength(version, EncodingMode.Byte));

string bitString = modeIndicator + countIndicator;
string bitString = "";
StringBuilder sb = new StringBuilder();
sb.Append(modeIndicator + countIndicator);
foreach (byte b in binaryData)
{
bitString += DecToBin(b, 8);
sb.Append(DecToBin(b, 8));

}
bitString = sb.ToString();


return GenerateQrCode(bitString, eccLevel, version);
}
Expand Down