Skip to content

Conversation

@Shane32
Copy link
Owner

@Shane32 Shane32 commented Oct 10, 2025

This adds the exact error messages that would be common to see due to GDI+ into the readme, within a very concise troubleshooting section.

Summary by CodeRabbit

  • Documentation
    • Added a Troubleshooting section to the README that explains System.Drawing.Common warnings affecting QRCode and ArtQRCode renderers, lists common error scenarios, and provides four recommended solutions.
    • Clarifies issues for users without introducing any functional changes or public API modifications.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

Documentation update: README.md gains a Troubleshooting section about System.Drawing.Common warnings for QRCode and ArtQRCode renderers, listing common errors and four solutions. The section appears duplicated in the diff. No code or API changes.

Changes

Cohort / File(s) Summary
Documentation
README.md
Added Troubleshooting section covering System.Drawing.Common warnings for QRCode/ArtQRCode renderers with common errors and four suggested fixes; section appears duplicated; no functional code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately describes the main change of adding a troubleshooting section for System.Drawing.Common warnings to the README, matching the documentation-focused diff without introducing ambiguity or extraneous detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch oshelp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

183-189: Add language hint to fenced warning block.

markdownlint (MD040) complains about the new fence lacking a language tag; annotating it (e.g., text) keeps the formatting and satisfies lint. Please patch as follows:

-```
+```text
 CA1416: This call site is reachable on all platforms. 'QRCode.QRCode(QRCodeData)' is only supported on: 'windows'
 
 System.TypeInitializationException: The type initializer for 'Gdip' threw an exception.
 
 System.PlatformNotSupportedException: System.Drawing.Common is not supported on this platform.

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used**: CodeRabbit UI

**Review profile**: CHILL

**Plan**: Pro

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 03c57bbcf4b96aed2aee095f469353642a03ab96 and ba6554cd0a590f77f7032e791a1a926690463997.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `README.md` (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.18.1)</summary>

<details>
<summary>README.md</summary>

183-183: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)</summary>

* GitHub Check: Test .NET Core 3.1
* GitHub Check: Test .NET 5.0 Windows
* GitHub Check: Test .NET 6.0 Windows
* GitHub Check: Test .NET Framework 4.6.2
* GitHub Check: additional-tests
* GitHub Check: Test .NET Core 2.1

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@Shane32 Shane32 requested a review from gfoidl October 10, 2025 17:32
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

183-189: Annotate the fenced block with a language.

markdownlint (MD040) flags the new code fence for missing a language. Add text (or similar) so the docs build stays clean. Apply this diff:

-```
+```text
 CA1416: This call site is reachable on all platforms. 'QRCode.QRCode(QRCodeData)' is only supported on: 'windows'
 
 System.TypeInitializationException: The type initializer for 'Gdip' threw an exception.
 
 System.PlatformNotSupportedException: System.Drawing.Common is not supported on this platform.

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used**: CodeRabbit UI

**Review profile**: CHILL

**Plan**: Pro

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 03c57bbcf4b96aed2aee095f469353642a03ab96 and 0f2f99f68fcfb33e7a96277c7372f6f56475b449.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `README.md` (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.18.1)</summary>

<details>
<summary>README.md</summary>

183-183: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)</summary>

* GitHub Check: Test .NET 5.0 Windows
* GitHub Check: Test .NET Core 3.1
* GitHub Check: Test .NET Core 2.1
* GitHub Check: Test .NET Framework 4.6.2
* GitHub Check: Test .NET 6.0 Windows
* GitHub Check: additional-tests

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

@Shane32 Shane32 self-assigned this Oct 10, 2025
@Shane32 Shane32 added the documentation Project documentation or source code documentation label Oct 10, 2025
@Shane32 Shane32 added this to the 1.7.1 milestone Oct 10, 2025
@Shane32
Copy link
Owner Author

Shane32 commented Oct 10, 2025

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

183-189: Specify a fenced code language for lint compliance.

Markdownlint flags this block (MD040). Add a language hint like ```text to keep CI clean.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f2f99f and dd0053a.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

183-183: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Test .NET 5.0 Windows
  • GitHub Check: Test .NET 6.0 Windows
  • GitHub Check: Test .NET Core 2.1
  • GitHub Check: Test .NET Framework 4.6.2
  • GitHub Check: Test .NET Core 3.1
  • GitHub Check: additional-tests

Copy link
Collaborator

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🏻

@Shane32 Shane32 merged commit 6c3fd5e into master Oct 10, 2025
8 checks passed
@Shane32 Shane32 deleted the oshelp branch October 10, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Project documentation or source code documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants