-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
area:spfxCategory: SharePoint Framework (not extensions related)Category: SharePoint Framework (not extensions related)status:trackedCurrently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)type:bug-suspectedSuspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Milestone
Description
Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
Windows
What browser(s) / client(s) have you tested
- 💥 Internet Explorer
- 💥 Microsoft Edge
- 💥 Google Chrome
- 💥 FireFox
- 💥 Safari
- mobile (iOS/iPadOS)
- mobile (Android)
- not applicable
- other (enter in the "Additional environment details" area below)
Additional environment details
- SPFx version 1.17.3
- Node.js version 16.20.0
Describe the bug / error
When I run gulp serve the placeholder {tenantDomain} in serve.json is not replaced with SPFX_SERVE_TENANT_DOMAIN environment variable.
If I correctly understood the issue happens because placeholder case-sensitive.
In the file SpfxServeTask.js in the method _getPlaceHolderDomainName expression placeHolderDomainName.includes(TENANT_DOMAIN_PLACEHOLDER) retruns false because
placeHolderDomainNameis https://{tenantdomain}/SitePages/myPage.aspx?...- but
TENANT_DOMAIN_PLACEHOLDERis {tenantDomain} (different case).
Placeholder is changed from {tenantDomain} to {tenantdomain} in the method _convertServeConfigurationToPageUrl.
Steps to reproduce
$env:SPFX_SERVE_TENANT_DOMAIN = "mydomain.sharepoint.com"gulp serve
Expected behavior
Placeholder {tenantDomain} is replaced with SPFX_SERVE_TENANT_DOMAIN environment variable value.
Metadata
Metadata
Assignees
Labels
area:spfxCategory: SharePoint Framework (not extensions related)Category: SharePoint Framework (not extensions related)status:trackedCurrently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)type:bug-suspectedSuspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.