Skip to content

Fix the installation of dependencies on app creation in Windows environments #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2022

Conversation

pepicrft
Copy link
Contributor

Related: #320

WHY are these changes introduced?

Acceptance tests uncovered Yarn installation errors in Windows environments when it tries to concurrently access the global cache.

WHAT is this pull request doing?

I'm adjusting the app creation logic to limit the concurrency to one as recommended here by other Yarn users. Some are experiencing it with newer versions of Yarn too so it seems that the issue is rooted in some core business logic of Yarn.

How to test your changes?

Acceptance tests should pass on Windows

@pepicrft pepicrft self-assigned this Aug 19, 2022
@pepicrft pepicrft requested a review from a team as a code owner August 19, 2022 12:58
@pepicrft pepicrft requested a review from a team August 19, 2022 12:58
@github-actions

This comment has been minimized.

Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice

@pepicrft pepicrft mentioned this pull request Aug 19, 2022
@pepicrft pepicrft requested a review from a team August 19, 2022 13:06
@pepicrft pepicrft merged commit 6ee3a6e into main Aug 19, 2022
@pepicrft pepicrft deleted the fix-install-windows branch August 19, 2022 14:41
@shopify-shipit shopify-shipit bot temporarily deployed to production August 22, 2022 16:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants