Merged
Conversation
We don't need to go through the memory names so let's avoid it.
No need a complex JSON if the function never reads it
Many tests used the "runtime_function" for which we no longer had the source checked in. Diggin, I found that it tried to approximate 5ms of runtime in production. It also uses an old input style. Using `exit_code.wasm` lets us test the same things with less baggage. I also merged the `exit(0)` and `exit(1)` Wasms into 1 Wasm that reads its exit code from stdin. As a result, we can drop 2 (large-ish) Wasm fixtures and 2 JSON files
jbourassa
commented
Feb 20, 2024
Contributor
Author
There was a problem hiding this comment.
I extract this from the Wasm file we had by reading the custom data section.
andrewhassan
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "benchmarks" folders hosted test fixtures and "benchmarks" that were meant to give users an idea of how close they are to limits. Those benchmarks are now irrelevant:
The only reason to carry these examples around now are test fixtures. This PR makes this clear, and cleans up the fixtures:
The diff is large, but the PR should be easy to review by looking at the individual commits.