return non-zero error code when function run sees error

[jacobsteves]

We want to support returning a non-zero error code anytime a module sees an error during a run.

Heres an example output:

 ✘  ~/src/github.com/Shopify/function-runner   js.return-error-when-module-errors  function-runner -f 'panic-configurable-fuel.wasm' -i 'input.json' -e run
            Input
{ manually truncated }
            Logs

thread '<unnamed>' panicked at src/run.rs:24:5:
oh no - something terrible has happened
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error while executing at wasm backtrace:
    0: 0x17c4e - <unknown>!<wasm function 366>
    1: 0x84a9 - <unknown>!<wasm function 14>
    2: 0x13f68 - <unknown>!<wasm function 108>
    3: 0x17bf8 - <unknown>!<wasm function 355>
    4: 0x171b0 - <unknown>!<wasm function 243>
    5: 0x17182 - <unknown>!<wasm function 242>
    6: 0x57b8 - <unknown>!<wasm function 9>

        Invalid Output


         JSON Error

EOF while parsing a value at line 1 column 0

        Resource Limits


Input Size: 125.00KB
Output Size: 19.53KB
Instructions: 11M


     Benchmark Results

Name: panic-configurable-fuel.wasm
Linear Memory Usage: 1088KB
Instructions: 150.943K
Input Size: 4.98KB
Output Size: 0B
Module Size: 112KB


Error: The Function execution failed. Review the logs for more information.
 ✘  ~/src/github.com/Shopify/function-runner   js.return-error-when-module-errors  echo $?
1

[andrewhassan]

I think we stopped auto-updating in this PR, which was released in the 3.65.0 version on August 2. I wonder if that's enough time that it would be okay to ship this PR as the default behaviour.

@nickwesselman Do you have an opinion on this?

[jeffcharles]

Could we make a case for a breaking change for older versions of the Shopify CLI here? I would imagine we would want older versions of the CLI to error out in these cases. But if not, this seems fine.

[jeffcharles]

This seems like a pretty long flag name to me. Unfortunately I don't have a constructive suggestion for something more succinct.

[jacobsteves]

Could we make a case for a breaking change for older versions of the Shopify CLI here?

I think it could be fair to make a case on that. It would make the changes here much nicer. I'll wait to see if Nick has an opinion there.

[jacobsteves]

I got confirmation from Nick that we can release this with a changelog without needing a command line option. I'll release a new 7.0 version once this ships.

As a side effect of removing the option, some integration tests started failing because the test fixture produced an invalid result. Thats been fixed by this commit.

[jeffcharles]

🥇