Patch fetchIndexesViaSqlDB in go-mysql to not return invisible indexes #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grodowski
force-pushed
the
grodowski/patch-hide-invisible-index-hints
branch
from
406ad9d to
674ba76
Compare
coding-chimp
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves an issue where
ghostferryselects an invisible index as theshardingKeyIndexName.The proper fix would be to patch
go-mysqlupstream to return a newVisiblefield inschema.Index, and then use it to filter the invisible ones inghostferry. I think it's worth shipping like this first though.