Add generated code to git to simplify use as a git submodule #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the project as a git submodule, gradle tries to compile and run the tests, which fails because of the missing generated file.
eapache
approved these changes
Feb 23, 2017
Contributor
eapache
left a comment
eapache
left a comment
There was a problem hiding this comment.
being able to review the generated code might be useful.
👍
DanielJette
approved these changes
Feb 23, 2017
Contributor
DanielJette
left a comment
DanielJette
left a comment
There was a problem hiding this comment.
👍 LGTM
🎩 with Mobile Shopify ✅
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the project as a git submodule, gradle tries to compile and run the tests, which fails because of the missing generated file.
Solution
For now, just check the generated code into version control.
This shouldn't be so bad since we already do this in mobile-shopify, and being able to review the generated code might be useful.