InputValue [4 of 4] #14
Conversation
- add InputValue type and extensions - modify generation to use InputValue enums in serialize() - declare all optional values in Input objects at InputValue<T>
| input_fields.each do |field| | ||
| text << escape_reserved_word(field.camelize_name) | ||
| text << ": " | ||
| text << swift_input_type(field.type, wrapped: true) |
There was a problem hiding this comment.
This looks like a painful way to generate code 😕 I think graphql_swift_gen.rb is more of a place to do some calculated logic rather then template the entire init. Having a function that is constantly appening to a string isn't nearly as readable or friendly as using embedded ruby. This should be in type.swift.erb.
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
| // |
There was a problem hiding this comment.
Rather than adding this license to all generated files why not pass in any licence you want based on the use case? Like if this is part of Buy SDK the pass in the buy SDK license.
|
|
||
| public var orUndefined: InputValue<Wrapped> { | ||
| return InputValue(orUndefined: self) | ||
| } |
There was a problem hiding this comment.
These optional extensions feel redundant to me. Not everyone will want to use them. These could be removed from the generator. Consumers that want this extension can always build it themselves.
dbart01
changed the base branch from
task/revert-explicit-null
to
task/docs
What this does
nullvalues viaInputType<T>Relies on #19