Handle max binlog size exceeded error with smaller batch #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coding-chimp
reviewed
Aug 5, 2024
…ries with smaller batch
…ch size is decreased when binlog cache size is exceeded, and error is thown when cannot reduce batch size further
…n raising in backoff function
Saadkhalid913
force-pushed
the
handle-max-binlog-size-exceeded-error-with-smaller-batch
branch
from
0f33b07 to
d6c9a52
Compare
coding-chimp
approved these changes
Aug 8, 2024
Author
|
Agent successfully ran migration with this version of LHM, and retried with smaller batch size and no errors, logs below |
chenhuiyeh
reviewed
Aug 15, 2024
chenhuiyeh
reviewed
Aug 15, 2024
chenhuiyeh
approved these changes
Aug 16, 2024
coding-chimp
deleted the
handle-max-binlog-size-exceeded-error-with-smaller-batch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a rescue clause into the chunker to handle only the error raised when binlog size is exceeded
We add a method to reduce stride size in throtter by a given % (default 20, configurable by user)
Backoff will keep happening until it reaches "MIN_STRIDE_SIZE" (set to 1 by now, not configurable at the moment)