Skip to content

Always return boolean in has filter#1946

Closed
ianks wants to merge 1 commit intomainfrom
has-boolean-arg
Closed

Always return boolean in has filter#1946
ianks wants to merge 1 commit intomainfrom
has-boolean-arg

Conversation

@ianks
Copy link
Copy Markdown
Contributor

@ianks ianks commented Apr 8, 2025

Previously, filter_array could return nil in certain cases which breaks the expectation that has should return a boolean. This PR fixes that.

@ianks ianks requested review from Maaarcocr and Copilot April 8, 2025 15:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

test/integration/standard_filter_test.rb:984

  • [nitpick] The duplicate assertion in test_has_with_boolean_input may be redundant; consider removing one to avoid unnecessary repetition in the test suite.
assert_template_result("Result: false", template, { "a0" => false })

@ianks ianks force-pushed the has-boolean-arg branch from cd0af64 to 678d947 Compare April 8, 2025 15:35
@ianks ianks closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants