fix: remove duplicate bundledDependencies config #2259
+8
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove both bundledDependencies and bundleDependencies fields to fix npm workspace compatibility issues. The package.json had both spellings with inconsistent values: - bundledDependencies: ["@signalk/server-api"] - bundleDependencies: ["@signalk/server-api", "@signalk/server-admin-ui"] This conflicts with npm's workspace support (npm/cli#3466) and causes dependencies to be missing from the published tarball. Also fix WASM test to use correct config directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove both
bundledDependenciesandbundleDependenciesfields to fix npm workspace compatibility.Problem
The package.json had both spellings with inconsistent values:
bundledDependencies:["@signalk/server-api"]bundleDependencies:["@signalk/server-api", "@signalk/server-admin-ui"]This conflicts with npm's workspace support (npm/cli#3466) and causes dependencies to be missing from global installs, breaking Docker builds.
Verification
This fix cannot be fully tested locally because the workspace packages (
@signalk/server-api, etc.) need to be published to npm first. Please verify by:docker run -d -p 3000:3000 ghcr.io/signalk/signalk-server:<sha>