Skip to content

Allow users to provide their own THROW_PRETTY and CHECK_ARGUMENT_SIZE macros #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

kermado
Copy link

@kermado kermado commented Apr 20, 2025

This small change allows users to define their own macros, allowing exceptions and some argument checking to be disabled.

@hrp2-14
Copy link
Member

hrp2-14 commented Apr 20, 2025

Hi ! This project doesn't usually accept pull requests on the main branch.
If this wasn't intentionnal, you can change the base branch of this PR to devel
(No need to close it for that). Best, a bot.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kermado kermado changed the base branch from main to devel April 20, 2025 22:00
@fabinsch
Copy link
Collaborator

hi @kermado, could you please revert the second commit adding the config.hpp which is a built artifact. I believe this is not related to your proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants