Windows experience white "flickering" when rendered in scenes

[georgewsinger]

https://www.youtube.com/watch?v=zo4Sv2sgxaU @KaneTW

• This only occurs under scenes
• This happens whether or not we used BakedLightmap or GIProbe light rendering

[KaneTW]

Seems like something in the rendering chain for the windows still has a normally shaded material. Default materials will actually shade (= account for reflections), and that are the white spots.

This is weird, since we run "unshaded" for the text shader. Something must have a default material somewhere.

[georgewsinger]

@KaneTW

• I reviewed our codebase and, as far as I can tell, we're only ever using ShaderMaterial.
• I tried setting our GSVS Viewports to have

-- DEBUG_DRAW_UNSHADED = 1 --- Objects are displayed without light information.
G.set_debug_draw renderTarget G.DEBUG_DRAW_UNSHADED

but the issue persists.

[KaneTW]

it's sufficient that we're not setting a material somewhere. open up the scene graph in the godot editor and check the mesh body that we're drawing to?

[georgewsinger]

1. The ViewportBase didn't have any materials set. I tried applying one of our text shaders as a test, and it had no effect.
2. The MeshInstance (which we store a QuadMesh to) also didn't have any material set to it. I tried both of the following:

newGodotSimulaViewSprite :: GodotSimulaServer -> SimulaView -> IO (GodotSimulaViewSprite)
newGodotSimulaViewSprite gss simulaView = do
  -- ..
  meshInstance <- unsafeInstance GodotMeshInstance "MeshInstance"
  quadMesh <- unsafeInstance GodotQuadMesh "QuadMesh"
  -- ..
  count <- G.get_surface_material_count meshInstance
  putStrLn $ "surface material count: " ++ (show count) -- Prints as "1"
  -- Set to shader material as a test
  premulshm <- load GodotShaderMaterial "ShaderMaterial" "res://addons/godot-haskell-plugin/CanvasPremulShader.tres"
  case (premulshm) of
    (Just premulshm) -> do
        G.set_surface_material meshInstance 0 (safeCast premulshm) -- Causes gsvs to be rendered invisibly; compositor is unstable
        G.set_material quadMesh (safeCast premulshm) -- Has no effect, even within the godot editor. Sparkes still occur.
    _ -> return ()

[georgewsinger]

@KaneTW Constructing a SpatialMaterial and setting it also causes invisibly rendered QuadMesh:

  spatialMaterial <- unsafeInstance GodotSpatialMaterial "SpatialMaterial"
  G.set_flag spatialMaterial G.FLAG_UNSHADED True
  G.set_flag spatialMaterial G.FLAG_DONT_RECEIVE_SHADOWS True
  G.set_flag spatialMaterial G.FLAG_DISABLE_AMBIENT_LIGHT True
  G.set_surface_material meshInstance 0 (safeCast spatialMaterial)

[georgewsinger]

Can't think of a single time /r/godot has actually answered a question I've posted, but I threw up the issue: https://www.reddit.com/r/godot/comments/ourg7q/quadmesh_exhibit_unwanted_sparkle_lighting_effects/