Skip to content

RecolorBrush - Limit access to target dimensions #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JimBobSquarePants merged 2 commits into from
Jan 8, 2025
Merged

RecolorBrush - Limit access to target dimensions #350

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd3afa0
Limit access to target dimensions
JimBobSquarePants Jan 8, 2025
51173a8
Remove unused variable
JimBobSquarePants Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ImageSharp.Drawing.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ISSUE_TEMPLATE", "ISSUE_TEMPLATE", "{FBE8C1AD-5AEC-4514-9B64-091D8E145865}"
ProjectSection(SolutionItems) = preProject
.github\ISSUE_TEMPLATE\config.yml = .github\ISSUE_TEMPLATE\config.yml
.github\ISSUE_TEMPLATE\oss-bug-report.md = .github\ISSUE_TEMPLATE\oss-bug-report.md
.github\ISSUE_TEMPLATE\oss-bug-report.yml = .github\ISSUE_TEMPLATE\oss-bug-report.yml
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{815C0625-CD3D-440F-9F80-2D83856AB7AE}"
Expand Down
12 changes: 10 additions & 2 deletions src/ImageSharp.Drawing/Processing/RecolorBrush.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,17 @@ public RecolorBrushApplicator(
/// <inheritdoc />
public override void Apply(Span<float> scanline, int x, int y)
{
Span<float> amounts = this.blenderBuffers.AmountSpan.Slice(0, scanline.Length);
Span<TPixel> overlays = this.blenderBuffers.OverlaySpan.Slice(0, scanline.Length);
if (x < 0 || y < 0 || x >= this.Target.Width || y >= this.Target.Height)
{
return;
}

// Limit the scanline to the bounds of the image relative to x.
scanline = scanline[..Math.Min(this.Target.Width - x, scanline.Length)];
Span<float> amounts = this.blenderBuffers.AmountSpan[..scanline.Length];
Span<TPixel> overlays = this.blenderBuffers.OverlaySpan[..scanline.Length];

int width = this.Target.Width;
Copy link

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable 'width' is declared but not used. It should be removed to avoid confusion.

Suggested change
int width = this.Target.Width;
// int width = this.Target.Width;

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@JimBobSquarePants JimBobSquarePants Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly correct. It's best to delete than comment out.

for (int i = 0; i < scanline.Length; i++)
{
amounts[i] = scanline[i] * this.Options.BlendPercentage;
Expand Down
Loading