Skip to content

Conversation

@UnknownShadow200
Copy link

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

The Image.Identify/IdentifyAsync overloads that took byte arrays or file paths as the input argument still referred to them as a stream in their documentation

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.


/// <summary>
/// Reads the raw image information from the specified stream without fully decoding it.
/// Reads the raw image information from the given encoded byte array without fully decoding it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also using encoded in other comments?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For byte arrays, IdentifyFormat doesn't call them encoded in <summary> but Load does, so I went with the latter for consistency

Although the <summary> for streams/files doesn't mention encoded at all, so I can remove encoded from <summary> for byte arrays if preferable

@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Jan 14, 2023

Replaced by #2317 as the APIs are being refactored. @UnknownShadow200 thanks for your help here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants