Skip to content

Refactor to use Microsoft.Build#102

Merged
MichielOda merged 2 commits into
mainfrom
MicrosoftBuild
Apr 8, 2026
Merged

Refactor to use Microsoft.Build#102
MichielOda merged 2 commits into
mainfrom
MicrosoftBuild

Conversation

@MichielOda

@MichielOda MichielOda commented Mar 31, 2026

Copy link
Copy Markdown
Member

This pull request introduces several important changes to the project, focusing on dependency management, build/test infrastructure, and codebase modernization. The main updates include centralizing and updating NuGet package management, refactoring project references to use newer packages, and updating the CI/CD workflow for improved compatibility and maintainability.

Dependency and Package Management:

  • Added Directory.Build.props, Directory.Packages.props, and NuGet.config for central and modern NuGet package management, specifying versions and controlling asset flow. [1] [2] [3]
  • Updated .github/dependabot.yml to ignore Microsoft.Build for automated dependency updates.

Build and CI/CD Pipeline Updates:

  • Refactored .github/workflows/release.yml to remove Ubuntu test jobs, update action versions, and switch to a new reusable workflow with improved parameter naming and additional build/test options.

Project Reference and Code Modernization:

  • Replaced all references to Skyline.DataMiner.CICD.Parsers.Common.VisualStudio.Projects with Skyline.DataMiner.CICD.Assemblers.Common.VisualStudio.Projects across the codebase for improved compatibility and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]
  • Updated logic in DmappCreation.cs and PublishToCatalog.cs to default to DataMinerProjectType.Unknown if conversion fails, improving error handling. [1] [2]

Testing Improvements:

  • Upgraded SdkTests.csproj to use the latest MSTest SDK, centralized package versions, and added a manual test class for debugging. [1] [2] [3]
  • Added minimal MSBuild files to test files and improved test categorization and reliability. [1] [2] [3] [4]

Packaging and Metadata:

  • Updated Sdk.csproj to modernize package metadata, adjust output paths, and clean up package references, aligning with new central package management.

These changes collectively improve the project's maintainability, build reliability, and compatibility with modern .NET development practices.

Comment thread Directory.Packages.props
@MichielOda MichielOda changed the title WIP - work with Microsoft.Build Refactor to use Microsoft.Build Apr 7, 2026
@MichielOda MichielOda merged commit ae84d40 into main Apr 8, 2026
9 of 10 checks passed
@MichielOda MichielOda deleted the MicrosoftBuild branch April 8, 2026 12:29
This was referenced Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant