Refactor to use Microsoft.Build#102
Merged
Merged
Conversation
23ccc39 to
6ac78a9
Compare
This was referenced Apr 8, 2026
Closed
Closed
Closed
Closed
This was referenced May 18, 2026
This was referenced Jun 1, 2026
This was referenced Jun 8, 2026
This was referenced Jun 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important changes to the project, focusing on dependency management, build/test infrastructure, and codebase modernization. The main updates include centralizing and updating NuGet package management, refactoring project references to use newer packages, and updating the CI/CD workflow for improved compatibility and maintainability.
Dependency and Package Management:
Directory.Build.props,Directory.Packages.props, andNuGet.configfor central and modern NuGet package management, specifying versions and controlling asset flow. [1] [2] [3].github/dependabot.ymlto ignoreMicrosoft.Buildfor automated dependency updates.Build and CI/CD Pipeline Updates:
.github/workflows/release.ymlto remove Ubuntu test jobs, update action versions, and switch to a new reusable workflow with improved parameter naming and additional build/test options.Project Reference and Code Modernization:
Skyline.DataMiner.CICD.Parsers.Common.VisualStudio.ProjectswithSkyline.DataMiner.CICD.Assemblers.Common.VisualStudio.Projectsacross the codebase for improved compatibility and maintainability. [1] [2] [3] [4] [5] [6] [7] [8]DmappCreation.csandPublishToCatalog.csto default toDataMinerProjectType.Unknownif conversion fails, improving error handling. [1] [2]Testing Improvements:
SdkTests.csprojto use the latest MSTest SDK, centralized package versions, and added a manual test class for debugging. [1] [2] [3]Packaging and Metadata:
Sdk.csprojto modernize package metadata, adjust output paths, and clean up package references, aligning with new central package management.These changes collectively improve the project's maintainability, build reliability, and compatibility with modern .NET development practices.